-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for the closest declination line RF model to produce the DL2 files #280
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 79.76% 81.58% +1.81%
==========================================
Files 59 57 -2
Lines 5144 4984 -160
==========================================
- Hits 4103 4066 -37
+ Misses 1041 918 -123 ☔ View full report in Codecov by Sentry. |
@moralejo, I was going to comment in today's meeting. The way we look for the adequate RF model declination track is by using the pointing information from the TCU database (specifically the target coordinates), not checking the average pointing information inside the data files as you mentioned. Is this fine? |
Since the relevant pointing is the one in celestial coordinates, the target coordinates are perfectly fine for standard observations (if we ever do something like drift scans we will anyway have to do some custom work). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! thanks @marialainez. I leave some comments. I'd like to test it a bit myself. How about the memory and time requirements of the jobs including the dl1 to dl2 stage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to push this forward. I left some comments. I think the tricky part is to readjust the job's requirements (time and memory) when including dl1 to dl2 step, although that is independent from this PR.
src/osa/paths.py
Outdated
|
||
if options.test or options.simulate: | ||
source_coordinates = SkyCoord.from_name(target_name[0]) | ||
source_dec = source_coordinates.dec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source_dec = run["source_dec"]
The pointing info is also available directly at the RunCatalog files (from TCU db). So in principle no need to access TCU db again.
I tested the dl2 production with this branch and it works correctly with MEMSIZE_DATA: 60 GB. |
see issue #275