-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check state of the jobs launched by autocloser #269
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 81.85% 81.72% -0.14%
==========================================
Files 57 57
Lines 4822 4864 +42
==========================================
+ Hits 3947 3975 +28
- Misses 875 889 +14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can go ahead with this, but keep in mind that cronjob frequency should change accordingly, with these changes the autocloser could be running up to 1 h checking for job proper completion.
Check that all the jobs launched by autocloser finished correctly before creating the NightFinished.txt file. See issue #263