Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the sbatch walltime #128

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Specify the sbatch walltime #128

merged 1 commit into from
Feb 25, 2022

Conversation

morcuended
Copy link
Member

  • Remove --cpus-per-task=1 SBATCH param, since 1 processor per task is the default.
  • Specify the walltime since we would need to schedule jobs in any partition
  • Adapt tests accordingly

… default. Specify walltime since we would need to schedule jobs in any partition and adapt tests
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #128 (153572c) into main (ea02cfe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   82.33%   82.33%           
=======================================
  Files          51       51           
  Lines        4901     4901           
=======================================
  Hits         4035     4035           
  Misses        866      866           
Impacted Files Coverage Δ
osa/job.py 79.71% <ø> (ø)
osa/tests/test_jobs.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea02cfe...153572c. Read the comment docs.

@morcuended morcuended merged commit 08047e7 into main Feb 25, 2022
@morcuended morcuended deleted the env-v093 branch February 25, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant