Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that only YYYYMMDD date directories are considered in glob when looking for run date #123

Merged
merged 7 commits into from
Feb 23, 2022

Conversation

morcuended
Copy link
Member

We had a problem with the same run_id found in two different date directories. One of them was renamed Trash but it's still in the data directory. Therefore when looking for the date parent directory it is giving problems. Here I forced that only date directories with the correct format are considered.

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #123 (6a71746) into main (98aefd1) will increase coverage by 0.01%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   82.23%   82.24%   +0.01%     
==========================================
  Files          51       51              
  Lines        4801     4811      +10     
==========================================
+ Hits         3948     3957       +9     
- Misses        853      854       +1     
Impacted Files Coverage Δ
osa/tests/test_jobs.py 100.00% <ø> (ø)
osa/paths.py 86.32% <83.33%> (-0.41%) ⬇️
osa/conftest.py 91.52% <100.00%> (ø)
osa/tests/test_paths.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98aefd1...6a71746. Read the comment docs.

@morcuended morcuended merged commit aa27b06 into main Feb 23, 2022
@morcuended morcuended deleted the fix-get-run-date branch February 23, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant