-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve setup and change source code layout to comply with PEP-660. #32
Conversation
Codecov ReportBase: 96.05% // Head: 87.05% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 96.05% 87.05% -9.00%
==========================================
Files 8 7 -1
Lines 228 510 +282
==========================================
+ Hits 219 444 +225
- Misses 9 66 +57
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
setup.cfg
Outdated
ctapipe~=0.12 | ||
numpy~=1.22 | ||
protozfits~=2.0 | ||
pytables>=3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name on pypi is tables, without the py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conda calls it pytables though (so it is correct in environment.yml)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @maxnoe ! How mean...
The change seems to work on my side. @frnbrun ca you confirm it fixed the problem you reported in cta-observatory/nectarchain#28 ? @jlenain I see one test failed with: |
@dkerszberg the test fails because there is no tag yet in this repository. Either switch it off for the time being, or create an |
Hi @dkerszberg, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to be merged
Thanks @jlenain and @dkerszberg ! |
Following @maxnoe 's path on
ctapipe_io_lst
, this PR proposes to improve thesetuptools
configuration to comply with PEP-660.