Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ctapipe 0.22 #230

Merged
merged 4 commits into from
Nov 11, 2024
Merged

support ctapipe 0.22 #230

merged 4 commits into from
Nov 11, 2024

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 8, 2024

We fixed scipy here to an issue in ctapipe, but this is fixed in the latest version of ctapipe and it doesn't make sense to limit it here in the package metadata.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.09%. Comparing base (3eb573d) to head (c26c370).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   91.09%   91.09%           
=======================================
  Files          25       25           
  Lines        2628     2629    +1     
=======================================
+ Hits         2394     2395    +1     
  Misses        234      234           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe maxnoe requested a review from moralejo November 8, 2024 20:58
@maxnoe maxnoe changed the title Remove scipy version pin support ctapipe 0.22 Nov 8, 2024
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@maxnoe maxnoe merged commit 964d98d into main Nov 11, 2024
9 checks passed
@maxnoe maxnoe deleted the scipy-pin branch November 11, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants