Fill r1 event type also for old data #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
force-pushed
the
r1_event_type
branch
3 times, most recently
from
34968e4 to
ae429e8
Compare
|
Thanks a lot @maxnoe! It worked for me locally, but it seems to fail the CI test for the older ctapipe version. |
maxnoe
force-pushed
the
r1_event_type
branch
from
9ac8739 to
06fcdf9
Compare
maxnoe
force-pushed
the
r1_event_type
branch
from
06fcdf9 to
c4544f3
Compare
|
Should be fixed now @TjarkMiener |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 89.59% 89.63% +0.03%
==========================================
Files 21 21
Lines 2365 2373 +8
==========================================
+ Hits 2119 2127 +8
Misses 246 246 ☔ View full report in Codecov by Sentry. |
morcuended
approved these changes
Dec 5, 2023
moralejo
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.