-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New time and geometry #19
New time and geometry #19
Conversation
module 132 (central module)
The problem here is that the correct geometry (version 3) is for the moment only in the master of ctapipe_extra, I will ask to get a new release but I don't know how long it will take. Should I add this geometry somewhere else? |
WARNING: it seems that the CDTS data model changed in the last version of the EvB. I am going to add to this PR the necessary change. |
See #18 |
Hi @FrancaCassol
|
Hi @morcuended, |
It would be possible to make it backward compatible? For example, check the version of the CDTS first, and then use the corresponding data model |
obviously, I will use the daq version to correctly read the data |
Hello Franca, |
Hi @mdpunch,
I think you got the point. Don't worry, I think the message arrived. |
Is the test failing because the current file |
The CameraGeometry is in ctapipe-extra and has nothing to do with the input data file. I would suggest that you add the lst camera geometry as a resource file in this repository, as it is clearly required for the lst event source. (pinging @kosack here) |
Hi @maxnoe, |
It's only 13 kB, so basically nothing |
it sounds like a good solution.
|
See #20 |
Hi Franca, |
…o_lst into new_time_and_geometry Conflicts: ctapipe_io_lst/__init__.py
Hi @mdpunch,
this is a big problem in my view, I also could not find the official place where this information is supposed to be. I got the data model one day from Julien (that is my only known official channel) and I had to limit my ambition to at least be informed if the output of the EvB is changing (in order to be able to modify the offline reader). I agree that this is not really satisfactory. |
This PR change the default geometry to the version 3 (in ctapipe_extra) which is in the Camera frame, version 2 was wrongly rotated
I also set the r0 trigger_time to the dragon time of the central module (to be changed when we get a correct ucts)