Fix set_line_hillas #974
Merged
Fix set_line_hillas #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasgas
previously approved these changes
Feb 20, 2019
maxnoe
requested changes
Feb 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
==========================================
- Coverage 77.74% 77.74% -0.01%
==========================================
Files 191 191
Lines 10831 10829 -2
==========================================
- Hits 8421 8419 -2
Misses 2410 2410
Continue to review full report at Codecov.
|
|
While you are at it, can you replace the |
kpfrang
force-pushed
the
fix_set_line_hillas
branch
from
2a39fb8 to
996bbeb
Compare
maxnoe
previously approved these changes
Feb 20, 2019
|
Nice, let's just wait for travis |
|
There was some accidental typo, which is fixed now. |
maxnoe
approved these changes
Feb 20, 2019
thomasgas
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of set_line_hillas did not work for huge values of
m. This is an quick fix which calculates the actual start end end points of the line exactly. This works also in the case of (almost) vertical lines as you can see in the plot attached.