-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waveform cleaner #973
Merged
watsonjj
merged 24 commits into
cta-observatory:master
from
FrancaCassol:waveform_cleaner
Feb 27, 2019
Merged
Waveform cleaner #973
Changes from 15 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
f1b8096
New directory tree for the atmosphere calibration code
FrancaCassol 66346d1
Fix doc error
FrancaCassol 88ad9d3
Merge branch 'master' of https://github.com/cta-observatory/ctapipe
cff4c0b
Merge branch 'master' of https://github.com/cta-observatory/ctapipe
b126726
Merge branch 'master' of https://github.com/cta-observatory/ctapipe
ee945fb
Merge branch 'master' of https://github.com/cta-observatory/ctapipe
FrancaCassol 8819d22
remove ctapipe/atmosphere and doc/atmosphere
FrancaCassol 474bf53
Merge branch 'master' of https://github.com/cta-observatory/ctapipe
FrancaCassol d74df8f
remove ctapipe/atmosphere and doc/atmosphere
FrancaCassol 653d4c7
Merge branch 'master' of https://github.com/cta-observatory/ctapipe
FrancaCassol 9d129a0
Merge branch 'master' of https://github.com/cta-observatory/ctapipe
FrancaCassol b41bfc0
Merge branch 'master' of https://github.com/cta-observatory/ctapipe
FrancaCassol 06764b4
Merge branch 'master' of https://github.com/cta-observatory/ctapipe
FrancaCassol 69433e5
Added BaselineWaveformCleaner which returns the waveform baseline sub…
FrancaCassol 7fe79bd
Improved code comments
FrancaCassol 7bbafb2
Corrected bug and added test of baseline_cleaner
FrancaCassol 78e8b7d
Change of the BaselineWaveformCleaner argument names
FrancaCassol 326c2cf
Minor changes for Travis
FrancaCassol a010a59
Style changes
FrancaCassol 0dfaa12
Style change
FrancaCassol 76b0105
Changed argument name in a more meaniful one
FrancaCassol e2d9853
Changed name of variable with better choice
FrancaCassol ad0cead
Merge branch 'master' into waveform_cleaner
watsonjj d585206
Add missing comma
watsonjj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
window_shift
is not equal to zero then it does not represents thebaseline_width
anymore right ?.I would suggest to call the two parameters :
sample_start
sample_end