Avoid underscore replacement empty prefixes. #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #951 +/- ##
=======================================
Coverage 78.86% 78.86%
=======================================
Files 191 191
Lines 10966 10966
=======================================
Hits 8648 8648
Misses 2318 2318
Continue to review full report at Codecov.
|
kosack
approved these changes
Feb 6, 2019
maxnoe
reviewed
Feb 6, 2019
| @@ -151,7 +151,7 @@ class Schema(tables.IsDescription): | |||
| continue | |||
|
|
|||
| if isinstance(value, Quantity): | |||
| if self.add_prefix: | |||
| if self.add_prefix and container.prefix: | |||
| key = col_name.replace(container.prefix + '_', '') | |||
There was a problem hiding this comment.
I think what we really want to do here (and there might be other places where this is needed) is:
import re
key = re.sub(f'^{prefix}_', '', col_name)This makes sure, prefix_ is only removed at the beginning of the column name.
dneise
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underscore replacment would match every string when the prefix was empty.