fixed examples that use pandas to read hdf5 #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed `read_hdf(filename)` to `read_hdf(filename, key='xxx') everywhere`. This avoids bug in latest pandas where finding the first dataset automatically fails.
|
Oh, I also made a small edit to the LST bootcamp notebook: in it the single-tel parameters were labeled as DL2, but that is actually DL1, following the CTA definitions. Doesn't change the code at all though. |
Codecov Report
@@ Coverage Diff @@
## master #940 +/- ##
=======================================
Coverage 78.57% 78.57%
=======================================
Files 191 191
Lines 10867 10867
=======================================
Hits 8539 8539
Misses 2328 2328
Continue to review full report at Codecov.
|
dneise
approved these changes
Jan 28, 2019
watsonjj
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed
read_hdf(filename)toread_hdf(filename, key='xxx') everywhere. This avoids bug in latest pandas where finding the first dataset automatically fails.Fixes #938 (with workaround to avoid using automatic dataset detection)