Regression features in RegressorClassifierBase
#764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the model - used in show_importances
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
=========================================
+ Coverage 70.74% 70.95% +0.2%
=========================================
Files 198 198
Lines 10676 10691 +15
=========================================
+ Hits 7553 7586 +33
+ Misses 3123 3105 -18
Continue to review full report at Codecov.
|
kosack
approved these changes
Jun 25, 2018
|
could you add a unit test as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added dictionaries to the class so that we can track what features have been used to train the model.
This will be particularly handy when the model is saved on disk and used elsewhere.