Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HillasParametersContainer only #763

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jun 19, 2018

No description provided.

@maxnoe maxnoe force-pushed the remove_moments_master branch from e89dafa to 9980a4c Compare June 19, 2018 08:45
@maxnoe maxnoe requested a review from kosack June 19, 2018 08:47
@maxnoe maxnoe force-pushed the remove_moments_master branch 2 times, most recently from 3b28de3 to 537ba27 Compare June 19, 2018 09:20
@maxnoe maxnoe force-pushed the remove_moments_master branch from 537ba27 to 95344fc Compare June 19, 2018 10:18
@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #763 into master will decrease coverage by 0.03%.
The diff coverage is 48.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
- Coverage   70.78%   70.74%   -0.04%     
==========================================
  Files         198      198              
  Lines       10688    10676      -12     
==========================================
- Hits         7565     7553      -12     
  Misses       3123     3123
Impacted Files Coverage Δ
ctapipe/reco/ImPACT.py 21.58% <0%> (ø) ⬆️
ctapipe/reco/hillas_intersection.py 25.82% <0%> (ø) ⬆️
ctapipe/plotting/array.py 0% <0%> (ø) ⬆️
ctapipe/image/hillas.py 97.54% <100%> (-0.07%) ⬇️
ctapipe/image/tests/test_hillas.py 100% <100%> (ø) ⬆️
ctapipe/reco/HillasReconstructor.py 96.49% <100%> (ø) ⬆️
ctapipe/visualization/mpl_camera.py 79.88% <14.28%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c6ece5...95344fc. Read the comment docs.

@maxnoe
Copy link
Member Author

maxnoe commented Jun 19, 2018

Tests are passing now

@maxnoe maxnoe closed this Jun 19, 2018
@maxnoe maxnoe reopened this Jun 19, 2018
Copy link
Contributor

@kosack kosack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was on the list of things to do for too long.

@kosack kosack merged commit 37652e6 into cta-observatory:master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants