Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/muon bugs #762

Merged
merged 16 commits into from
Jun 18, 2018
Merged

Fix/muon bugs #762

merged 16 commits into from
Jun 18, 2018

Conversation

kosack
Copy link
Contributor

@kosack kosack commented Jun 18, 2018

Some small updates for the muon code (that clearly had no tests!) to work with newer Containers. Mainly, this is to use astropy.coordinate.Angle in mcheader.run_array_direction and muon_reco_functions.py, and also fix a typo.

I'll add some unit tests too

@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #762 into master will increase coverage by 0.78%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #762      +/-   ##
==========================================
+ Coverage   69.94%   70.72%   +0.78%     
==========================================
  Files         197      198       +1     
  Lines       10659    10669      +10     
==========================================
+ Hits         7455     7546      +91     
+ Misses       3204     3123      -81
Impacted Files Coverage Δ
ctapipe/image/muon/tests/test_muon_features.py 100% <ø> (ø)
ctapipe/image/muon/tests/test_muon_fitting.py 100% <ø> (ø)
ctapipe/image/muon/tests/test_muon_reco.py 100% <100%> (ø)
ctapipe/io/hessioeventsource.py 95.23% <100%> (ø) ⬆️
ctapipe/image/muon/muon_reco_functions.py 66.96% <66.66%> (+66.96%) ⬆️
ctapipe/coordinates/angular_frames.py 84.45% <0%> (+4.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff6ec8a...fbe1cb3. Read the comment docs.

@kosack kosack merged commit 4a784e8 into cta-observatory:master Jun 18, 2018
@kosack kosack deleted the fix/muon_bugs branch May 20, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant