Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MC xmax info #759

Merged
merged 2 commits into from
Jun 18, 2018
Merged

Add MC xmax info #759

merged 2 commits into from
Jun 18, 2018

Conversation

kbruegge
Copy link
Member

Adds the xmax info to the MC container. This can be used as soon as the new pyhessio is used in ctapipe with this PR cta-observatory/pyhessio#62

@kosack
Copy link
Contributor

kosack commented Jun 15, 2018

I'll build a package for the new pyhessio and upload it shortly, then this should work.

@kosack
Copy link
Contributor

kosack commented Jun 15, 2018

there is now a pyhessio-2.1.0 package in the cta-observatory channel (for linux, mac, and py35, py36). Try updating the environment.yml and setup.py to require >=2.1 and see if it works. I haven't done any testing.

@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #759 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
+ Coverage   69.49%   69.49%   +<.01%     
==========================================
  Files         198      198              
  Lines       10708    10710       +2     
==========================================
+ Hits         7441     7443       +2     
  Misses       3267     3267
Impacted Files Coverage Δ
ctapipe/io/containers.py 100% <100%> (ø) ⬆️
ctapipe/io/hessioeventsource.py 95.16% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb969ec...e479aee. Read the comment docs.

@kbruegge
Copy link
Member Author

It works 👍

@kosack
Copy link
Contributor

kosack commented Jun 18, 2018

Great! Looks like it works. I'll merge it in.

@kosack kosack merged commit eac1d0b into master Jun 18, 2018
@kosack kosack deleted the true_xmax branch January 30, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants