Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example script for a simple event writer #746

Merged
merged 3 commits into from
May 31, 2018

Conversation

jjlk
Copy link
Contributor

@jjlk jjlk commented May 23, 2018

Hi @kosack ,
This PR adds an example script and a configuration file to save image information (e.g. moment) and event information (e.g. MC energy and id) in HDF5 format. I used the ctapipe.core.Tool class capabilities to handle the configuration file and the event processing (setup, start, finish). Some pre-selection cuts, wich are defined in the configuration file, are also applied using the ctapipe.utils.CutFlow class.

What do you think?

Afterwards, I plan to start from this script to make an other tool to write DL1+ data that could be used to fed a regressor and a classifier for energy regression and event discrimination, respectively. The goal will be to launch the script on the GRID with @bregeon scripts.

Cheers

@codecov
Copy link

codecov bot commented May 23, 2018

Codecov Report

Merging #746 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   69.06%   69.06%           
=======================================
  Files         196      196           
  Lines       10562    10562           
=======================================
  Hits         7295     7295           
  Misses       3267     3267

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b66d0b...ead1216. Read the comment docs.

@jjlk jjlk changed the title Add example script for simple event writer Add example script for a simple event writer May 23, 2018
@kosack
Copy link
Contributor

kosack commented May 31, 2018

Thanks! Once we have some advanced classes merged in like the EventPreparer (which will allow you to select image cleaning thresholds per telescope type, etc), we can eventually make this more powerful and move it to ctapipe.tools as an official tool, perhaps.

@kosack kosack merged commit d621e3b into cta-observatory:master May 31, 2018
@jjlk jjlk deleted the evt_writer_dl1plus branch June 1, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants