Muon reco changes

[rlopezcoto]

• Ring size container was previously created but not filled in the muon reco functions.

• As discussed during the meeting, added the possibility of analyzing muon rings without applying image cleaning. Set the cleaning option to True to make not to mess with the results people were getting in the past. This option, together with all those included at the beginning of muon_reco_functions.py should eventually be moved to an input card (@AMWMitchell are you planning to do it? I could help out if you want).

[codecov]

Codecov Report

Merging #736 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
- Coverage   69.01%   68.98%   -0.03%     
==========================================
  Files         196      196              
  Lines       10537    10541       +4     
==========================================
  Hits         7272     7272              
- Misses       3265     3269       +4

Impacted Files	Coverage Δ
ctapipe/image/muon/muon_reco_functions.py	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f810aec...a87b90f. Read the comment docs.

[kosack]

Yes, all of the hard-coded bits need to eventually move to config variables or a table that is loaded up from ctapipe_resources. But that can be a future refactoring

[kosack]

Can you add a simple test case to the unit tests with this option disabled?

[rlopezcoto]

Can you add a simple test case to the unit tests with this option disabled?

Unfortunately as it is implemented right now, the True value is hardcoded and it is difficult to write a test unit at the moment. I could implement this option as an input, but if all these variables are going to be moved to an input card/configuration file, it is probably not worth it to do it at the moment.
Anyways and as i said in the PR, the default value makes the code work as it was working up to now

[kosack]

Ok, I'll merge it now then, and we can leave refactoring the whole muon code to a later point