Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coord trafo #580

Merged
merged 8 commits into from
Nov 23, 2017
Merged

Coord trafo #580

merged 8 commits into from
Nov 23, 2017

Conversation

tino-michael
Copy link
Contributor

@tino-michael tino-michael commented Nov 21, 2017

added a module that contains some low-level coordinate transformation functions to bring various coordinate systems into the convention that is expected by my reconstruction tools -- i.e. right-handed x-y-z coordinate system with z->upwards and phi and theta in the standard (?) definitions: theta, angle to z-axis and phi, angle in the x-y-plane from the x-axis towards the y-axis.

By this approach, assuming that azimuth is measured from north towards east, the x-axis points north and y points west, so phi = -azimuth.
The camera coordinates are mirrored along the x-axis, so that y points "up" and x to the "right", as it is expected by pixel_position_to_direction.

@codecov
Copy link

codecov bot commented Nov 21, 2017

Codecov Report

Merging #580 into master will increase coverage by 0.02%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
+ Coverage   63.22%   63.24%   +0.02%     
==========================================
  Files         174      175       +1     
  Lines        9523     9537      +14     
==========================================
+ Hits         6021     6032      +11     
- Misses       3502     3505       +3
Impacted Files Coverage Δ
ctapipe/utils/__init__.py 100% <100%> (ø) ⬆️
ctapipe/reco/HillasReconstructor.py 95.79% <100%> (-0.33%) ⬇️
ctapipe/coordinates/__init__.py 100% <100%> (ø) ⬆️
ctapipe/utils/linalg.py 87.87% <100%> (ø) ⬆️
ctapipe/coordinates/coordinate_transformations.py 86.95% <86.95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74bc231...5a2bc45. Read the comment docs.

@kosack
Copy link
Contributor

kosack commented Nov 23, 2017

could you move the /utils/coordinate_transformations.py file to /coordinates/? It makes more sense there

@kosack kosack merged commit f085660 into cta-observatory:master Nov 23, 2017
@tino-michael tino-michael deleted the coord_trafo branch November 29, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants