Fix tool exit order #2662
Merged
Fix tool exit order #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
force-pushed
the
fix_tool_exit_order
branch
from
5be6b0e to
37a24c3
Compare
This comment has been minimized.
This comment has been minimized.
mexanick
previously approved these changes
Dec 2, 2024
maxnoe
force-pushed
the
fix_tool_exit_order
branch
2 times, most recently
from
d4af92b to
8e1d89c
Compare
Tobychev
reviewed
Dec 3, 2024
maxnoe
force-pushed
the
fix_tool_exit_order
branch
from
8e1d89c to
a287f07
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
kosack
approved these changes
Dec 4, 2024
|
@mexanick could you re-approve? |
mexanick
approved these changes
Dec 4, 2024
This comment has been minimized.
This comment has been minimized.
1 similar comment
Analysis Details1 Issue
Coverage and Duplications
Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now
finish_activityonly after the_exit_stackhas finished to ensure the finalization of theComponents of aToolhappens during the activity.