-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error in ctapipe-process in case telescope event is missing true image #2659
Conversation
7ed741c
to
488848a
Compare
Unfortunately, it's very hard to create a test case for this |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
As Konrad mentions in #2344, the proper solution is not really obvious as simply discarding the image from one telescope for a high energy event will discard a lot of potentially important information. How do we best keep track of the need to properly handle this issue in the reconstructors? Open an issue against each existing method? |
At least for now, we didn't encounter the problematic "event too bright for memory limits" case in prod6. Only the non problematic "event very dim". I'd process prod6 with this fix and then check the photo electron sums against the images with missing true images to check if we also need to worry about the "too bright case" |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c26a15d
to
bca7761
Compare
Analysis Details1 IssueCoverage and DuplicationsProject ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
Fixes #2344