Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in ctapipe-process in case telescope event is missing true image #2659

Merged
merged 9 commits into from
Dec 4, 2024

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 27, 2024

Fixes #2344

@maxnoe maxnoe force-pushed the fix_missing_true_image branch from 7ed741c to 488848a Compare November 27, 2024 08:44
@maxnoe
Copy link
Member Author

maxnoe commented Nov 27, 2024

Unfortunately, it's very hard to create a test case for this

This comment has been minimized.

1 similar comment

This comment has been minimized.

@maxnoe maxnoe requested review from kosack and Tobychev November 27, 2024 15:52
@maxnoe maxnoe added this to the v0.23.1 milestone Nov 27, 2024
kosack
kosack previously approved these changes Nov 28, 2024
Tobychev
Tobychev previously approved these changes Nov 28, 2024
@Tobychev
Copy link
Contributor

As Konrad mentions in #2344, the proper solution is not really obvious as simply discarding the image from one telescope for a high energy event will discard a lot of potentially important information.

How do we best keep track of the need to properly handle this issue in the reconstructors? Open an issue against each existing method?

@maxnoe
Copy link
Member Author

maxnoe commented Nov 28, 2024

At least for now, we didn't encounter the problematic "event too bright for memory limits" case in prod6.

Only the non problematic "event very dim".

I'd process prod6 with this fix and then check the photo electron sums against the images with missing true images to check if we also need to worry about the "too bright case"

@maxnoe maxnoe dismissed stale reviews from Tobychev and kosack via 5f71a61 November 28, 2024 14:20

This comment has been minimized.

@maxnoe maxnoe requested review from kosack and Tobychev November 28, 2024 16:20
kosack
kosack previously approved these changes Nov 29, 2024

This comment has been minimized.

Tobychev
Tobychev previously approved these changes Dec 2, 2024

This comment has been minimized.

@maxnoe
Copy link
Member Author

maxnoe commented Dec 2, 2024

@kosack @Tobychev with the new test file, sonarqube now passes. Please have a look again

@maxnoe maxnoe requested a review from Tobychev December 3, 2024 14:58
@maxnoe maxnoe force-pushed the fix_missing_true_image branch from c26a15d to bca7761 Compare December 3, 2024 14:59
Copy link

Passed

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage 94.30% Coverage (94.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.70% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

@maxnoe maxnoe merged commit db1722d into main Dec 4, 2024
13 checks passed
@maxnoe maxnoe deleted the fix_missing_true_image branch December 4, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants