-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note to CameraGeometry docs about from_name() #2485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosack
added
the
documentation-only
Label that will ensure code tests are skipped
label
Dec 19, 2023
camera_types is a set, you can't Index it |
Can we (also?) raise an actual code warning? i.e.:
|
Tobychev
previously approved these changes
Jan 8, 2024
kosack
force-pushed
the
fix_camerageom_docstring
branch
from
January 24, 2024 16:01
fc82879
to
07d1cd9
Compare
Tobychev
previously approved these changes
Jan 24, 2024
The docs failure here is real and due to the changes made |
Note that from_name() is not guaranteed to correspond with event data. Closes #2484
maxnoe
force-pushed
the
fix_camerageom_docstring
branch
from
March 22, 2024 11:33
07d1cd9
to
1316b41
Compare
maxnoe
approved these changes
Mar 22, 2024
maxnoe
removed
the
documentation-only
Label that will ensure code tests are skipped
label
Mar 22, 2024
maxnoe
force-pushed
the
fix_camerageom_docstring
branch
from
March 22, 2024 12:29
af06fa7
to
a9cf92f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2485 +/- ##
=======================================
Coverage 92.53% 92.54%
=======================================
Files 235 236 +1
Lines 20063 20089 +26
=======================================
+ Hits 18565 18591 +26
Misses 1498 1498 ☔ View full report in Codecov by Sentry. |
Tobychev
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that from_name() is not guaranteed to correspond with event data.
Closes #2484