Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable str/Path as input to get_hdf5_datalevels #2451

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 6, 2023

Fixes #2450

@maxnoe maxnoe force-pushed the path_input_h5_datalevels branch from ecbda95 to 6f74957 Compare November 6, 2023 13:10
Tobychev
Tobychev previously approved these changes Nov 6, 2023
@maxnoe maxnoe force-pushed the path_input_h5_datalevels branch from ad71589 to 279614f Compare November 17, 2023 11:30
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49ab82b) 60.60% compared to head (279614f) 60.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2451   +/-   ##
=======================================
  Coverage   60.60%   60.60%           
=======================================
  Files           3        3           
  Lines          33       33           
=======================================
  Hits           20       20           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe maxnoe merged commit a2b6072 into main Nov 22, 2023
13 checks passed
@maxnoe maxnoe deleted the path_input_h5_datalevels branch November 22, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_hdf5_datalevels seems broken
3 participants