Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump setuptools and setuptools scm versions #2447

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Conversation

morcuended
Copy link
Member

@morcuended morcuended commented Nov 2, 2023

Versions in the current build settings seem not compatible. Resolves #2445

Versions in current build settings seem not compatible
@maxnoe
Copy link
Member

maxnoe commented Nov 2, 2023

@morcuende, that doesn't seem to fix the build issue. The same error now pops up for eventio.

I will fix it there as well.

@maxnoe
Copy link
Member

maxnoe commented Nov 2, 2023

Looking carefully at the log, there seems to be something more amiss here.

THe mamba build shouldn't install eventio via pip.

It also reports a python version of 3.10 in the 3.11 build.

I think the step "fix PATH for macos" that is also executed on ubuntu runners is the issue

@maxnoe
Copy link
Member

maxnoe commented Nov 2, 2023

The pr introducing the "documentation-only" fixes broke this with a wrong logic condition.

@maxnoe maxnoe requested review from Tobychev and kosack November 2, 2023 11:52
@morcuended
Copy link
Member Author

thanks for the fixes @maxnoe

@maxnoe maxnoe merged commit 3c4f140 into main Nov 2, 2023
11 checks passed
@maxnoe maxnoe deleted the bump-setuptools-version branch November 2, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump setuptools version
3 participants