Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if tel_id exists when looking up TelescopeParameters #2429

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Check if tel_id exists when looking up TelescopeParameters #2429

merged 1 commit into from
Oct 26, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 26, 2023

Fixes #2233.

@maxnoe maxnoe force-pushed the fix_2233_telescope_parameter_nonexistent_telescope branch from a436d53 to d236f72 Compare October 26, 2023 13:22
@maxnoe maxnoe requested review from Tobychev and kosack October 26, 2023 13:32
@maxnoe maxnoe force-pushed the fix_2233_telescope_parameter_nonexistent_telescope branch from d236f72 to eba9cf9 Compare October 26, 2023 13:46
@maxnoe maxnoe merged commit 6817199 into main Oct 26, 2023
10 of 11 checks passed
@maxnoe maxnoe deleted the fix_2233_telescope_parameter_nonexistent_telescope branch October 26, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morcuended morcuended morcuended approved these changes

@Tobychev Tobychev Tobychev approved these changes

@kosack kosack Awaiting requested review from kosack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TelescopeParameterLookup does not check wether telescope is in attaached subarray
3 participants
@maxnoe @Tobychev @morcuended