Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for hillas parameters in TelescopeFrame to CameraDisplay #2347

Merged
merged 5 commits into from
Jun 14, 2023
Merged

Add support for hillas parameters in TelescopeFrame to CameraDisplay #2347

merged 5 commits into from
Jun 14, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jun 13, 2023 •
edited
Loading

  • test

@maxnoe maxnoe requested review from kosack and LukasNickel June 13, 2023 15:06
@maxnoe
Copy link
Member Author

maxnoe commented Jun 13, 2023

Besides the missing telescope frame support, I was annoyed by the text overlapping the ellipse, I now added a bit of code to put it just outside the ellipse, rotated so it never overlaps:

hillas_overlay.mp4

LukasNickel
LukasNickel previously approved these changes Jun 13, 2023
View reviewed changes
@maxnoe maxnoe marked this pull request as ready for review June 13, 2023 15:12
@maxnoe maxnoe mentioned this pull request Jun 13, 2023
Merged
@maxnoe maxnoe linked an issue Jun 13, 2023 that may be closed by this pull request
CameraDisplay does not support hillas parameters in TelescopeFrame for overlay_moments. #2346
Closed
@kosack
Copy link
Contributor

kosack commented Jun 14, 2023

I imagine this also has to be fixed in the Bokeh version?

@maxnoe
Copy link
Member Author

maxnoe commented Jun 14, 2023

I imagine this also has to be fixed in the Bokeh version?

Yes indeed. I will make another PR for the bokeh one

@maxnoe
Copy link
Member Author

maxnoe commented Jun 14, 2023

Thinking about it, I think it makes sense to do it together here...

@maxnoe
Copy link
Member Author

maxnoe commented Jun 14, 2023

Done

@maxnoe maxnoe merged commit 8759143 into main Jun 14, 2023
@maxnoe maxnoe deleted the overlay_telescope_frame branch June 14, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasNickel LukasNickel LukasNickel approved these changes

@kosack kosack kosack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CameraDisplay does not support hillas parameters in TelescopeFrame for overlay_moments.
3 participants
@maxnoe @kosack @LukasNickel