Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SoftwareTrigger for actual simtel files #2320

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Apr 27, 2023

Fixes #2321

@maxnoe maxnoe force-pushed the software_trigger_ndarray branch from ada5039 to 9bb79ed Compare April 27, 2023 17:22
@Tobychev
Copy link
Contributor

Tobychev commented May 2, 2023

I can't tell what was wrong, the linked issue helps somewhat, but even that doesn't actually say what the resulting error is so I've no idea if this PR will solve it 🤷‍♂️

@maxnoe
Copy link
Member Author

maxnoe commented May 2, 2023

@Tobychev not sure how to improve that, since:

  • the issue contains the actual reason for the Bug (assuming a python list vs. sources producing a numpy array)

  • this PR adds new tests testing both an artificial case (with lists and arrays) and one using a simtel event file as input.

What else is needed?

@maxnoe
Copy link
Member Author

maxnoe commented May 2, 2023

If you want to make sure, run the new tests with the code on Main, they fail with the error described in the issue

@maxnoe
Copy link
Member Author

maxnoe commented May 8, 2023

@Tobychev I updated the issue description with the full error message.

@maxnoe maxnoe added this to the v0.19.1 milestone May 8, 2023
@maxnoe maxnoe merged commit 17d07c4 into main May 10, 2023
@maxnoe maxnoe deleted the software_trigger_ndarray branch May 10, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StereoTrigger does only work when tels_with_trigger is a python list, real sources use numpy arrays
3 participants