Fix wrong activity meta being written into output files #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosack
previously approved these changes
Feb 20, 2023
|
Tests are currently failing because we as it is now, the .current_activity property does not autostart one when it doesn't exist. However, I think this is better, and we should move the starting a new activity to another place so it is clear whether something is currently running, just finished or nothing has been started yet |
maxnoe
force-pushed
the
fix_activity_meta
branch
2 times, most recently
from
49261f9 to
6c2c628
Compare
maxnoe
force-pushed
the
fix_activity_meta
branch
from
87e33bb to
926e46c
Compare
|
@kosack works now, please review |
LukasNickel
previously approved these changes
Mar 13, 2023
Tobychev
reviewed
Mar 13, 2023
kosack
approved these changes
Mar 16, 2023
Tobychev
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds the stop time.
Fixes #2260