-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a bit of clarification of how important classes
attribute is to the tool doc
#2231
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@Tobychev This PR contains also your benchmarks code. Probably because you started from that branch and not from master. To make sure you start a fresh branch from master for a new PR, you can do:
To fix it here, you can do |
Ah, and also please "strip out" the notebook, e.g. |
The actual changes to the docs and the Tool tutorial look good! |
Thanks! Looks good now. |
Besides added a minimal bit of clarification of how important
classes
attribute is to the tool doc, I also did some other changes to the example notebook:SecondaryMyComponent
, which means a later example doesn't result in a distracting error