Consistent overwrite #2213
Merged
Consistent overwrite #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
reviewed
Jan 12, 2023
nbiederbeck
reviewed
Jan 12, 2023
maxnoe
reviewed
Jan 13, 2023
nbiederbeck
previously approved these changes
Jan 13, 2023
- Remove all -f aliases - Check for conflict on setup - rename infile/outfile to input_path/output_path
- Make `overwrite` a flag on `Tool` - Check that output files do not exist or overwrite is turned on
LukasNickel
force-pushed
the
overwrite
branch
from
8ec3616 to
f0f0d89
Compare
maxnoe
reviewed
Jan 20, 2023
maxnoe
reviewed
Jan 20, 2023
- Use check_output in dump_trigger aswell - Dont require a list of files - Skip None files, removing the check from the train* tools
maxnoe
reviewed
Jan 20, 2023
maxnoe
previously approved these changes
Jan 20, 2023
nbiederbeck
reviewed
Jan 23, 2023
- Tools now only have --overwrite
nbiederbeck
requested changes
Jan 23, 2023
nbiederbeck
previously approved these changes
Jan 23, 2023
- Since Tool now has overwrite, we can use that directly in the tools. - It is only defined explicitly if the default behaviour has to be overwritten
|
With the newest changes I think we would benefit from a test, checking that overwriting works explicitly. |
kosack
previously approved these changes
Jan 24, 2023
kosack
reviewed
Jan 24, 2023
maxnoe
approved these changes
Jan 24, 2023
nbiederbeck
approved these changes
Jan 24, 2023
This was referenced Feb 2, 2023
maxnoe
reviewed
Feb 3, 2023
| @@ -98,18 +97,7 @@ def setup(self): | |||
| self.cross_validate = CrossValidator( | |||
| parent=self, model_component=self.regressor | |||
| ) | |||
| self.rng = np.random.default_rng(self.random_seed) | |||
There was a problem hiding this comment.
This line should have stayed, review missed it and no tests for n_events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess that would be an API change since we remove a flag from some tools?