Refactor initialization of telescope parameters, move to own module

[maxnoe]

I came across code I didn't first understand in the initialization of the TelescopeParameter traits, trying to improve the code, I ran into a circular import problem (as the straight forward code would need to check isinstance(trait, TelescopeParameter and TelescopeComponent is in a module imported by ctapipe.core.traits).

So the best solution was to move the TelescopeComponent / TelescopeParameter related things into their own submodule ctapipe.core.telescope_component.

I think this is an improvement.

The main change (aside from moving things around) is replacing this code:

# configure all of the TelescopeParameters
for trait in list(self.class_traits()):
    try:
        getattr(self, trait).attach_subarray(subarray)
    except (AttributeError, TypeError):
        pass

with

# configure all of the TelescopeParameters
for attr, trait in self.class_traits().items():
    if not isinstance(trait, TelescopeParameter):
        continue

    # trait is the TelescopeParameter descriptor at the class,
    # need to get the value at the instance, which will be a TelescopePatternList
    pattern_list = getattr(self, attr)
    if pattern_list is not None:
        pattern_list.attach_subarray(subarray)

which is I think much clearer.

This also has the additional benefit of not silently ignoring errors that could potentially happen in attach_subarray.

[nbiederbeck]

Suggested change

	instace
	Instance

[nbiederbeck]

Does this work when in init self._lookup = None?

[nbiederbeck]

I assume this does not happen in "normal operations" but we might type-hint in __init__ anyways

[nbiederbeck]

Maybe this should raise an exception, to have everything documented?

[nbiederbeck]

Suggested change

	("type", "*", 200.0), # should overwrite everything with 200.0
	("type", "*", 200.0), # should overwrite everything above with 200.0

[kosack]

yes, this is much easier to follow. I didn't like relying on an exception to type-check