Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs build for traitlets 5.8 and array field defaults #2173

Merged
merged 4 commits into from
Dec 21, 2022
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Dec 20, 2022

This fixes an issue we found when building the lstchain docs. Arrays were included with all numbers spanning multiple lines which made the sphinx build fail.

nbiederbeck
nbiederbeck previously approved these changes Dec 21, 2022
@maxnoe maxnoe changed the title Make sure array defaults in repr(Field) are concise Fix docs build for traitlets 5.8 and array field defaults Dec 21, 2022
@maxnoe maxnoe requested a review from nbiederbeck December 21, 2022 14:26
Copy link
Contributor

@nbiederbeck nbiederbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog entry is missing

@maxnoe
Copy link
Member Author

maxnoe commented Dec 21, 2022

@nbiederbeck We said that we start with changelogs using towncrier after the next release because we already have merged a lot of PRs without changelog.

@maxnoe maxnoe merged commit e7ee398 into master Dec 21, 2022
@maxnoe maxnoe deleted the field_default branch December 21, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants