Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quality query to display dl1 tool #2172

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Dec 19, 2022

No description provided.

nbiederbeck
nbiederbeck previously approved these changes Dec 21, 2022
@RuneDominik
Copy link
Member

Is there a reason to divert from the usual usage of QualityQuerys by not creating a child class here? Even though the default should be to plot all images, which is what is realized here.

@maxnoe
Copy link
Member Author

maxnoe commented Dec 21, 2022

Is there a reason to divert from the usual usage of QualityQuerys by not creating a child class here? Even though the default should be to plot all images, which is what is realized here.

Subclassing is only really needed to
a) change the defaults, or
b) add support for configuring two quality queries next to one-another in the config hierarchy

RuneDominik
RuneDominik previously approved these changes Dec 21, 2022
@maxnoe maxnoe dismissed stale reviews from RuneDominik and nbiederbeck via 1b37bdb December 21, 2022 16:05
@maxnoe maxnoe force-pushed the display-dl1-qualityquery branch from 8f2906b to 1b37bdb Compare December 21, 2022 16:05
@maxnoe maxnoe merged commit 984caa3 into master Jan 2, 2023
@maxnoe maxnoe deleted the display-dl1-qualityquery branch January 2, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants