fix import error in metadata: fails on systems without pwd
#2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosack
changed the title
pwdpwd
Codecov ReportBase: 92.77% // Head: 92.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2152 +/- ##
==========================================
- Coverage 92.77% 92.75% -0.03%
==========================================
Files 216 216
Lines 18045 18050 +5
==========================================
+ Hits 16741 16742 +1
- Misses 1304 1308 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
StFroese
previously approved these changes
Dec 5, 2022
|
We need to merge #2150 first to fix the docs build |
The standard library module `pwd` doesn't exist on all systems (e.g. Windows or WASM), so don't rely on it. This just replaces the call to it with a default value if it is not there. This feature was only used to get the user's name if they forgot to explicitly include it, so it should not break things if it fails (which it currently does).
kosack
force-pushed
the
fix/make_pwd_optional
branch
from
c0eecfa to
33fe0ca
Compare
maxnoe
approved these changes
Dec 6, 2022
nbiederbeck
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard library module
pwd(password database access) doesn't exist on all systems (e.g. Windows or WASM), so don't rely on it. This just replaces the call to it with a default value if it is not there.This feature was only used in
ctapipe.core.metadata.Contactto get the user's name if they forgot to explicitly include it, so it should not break things if it fails (which it currently does).