Implement stereo trigger for subarray triggers #2136
Conversation
maxnoe
force-pushed
the
software_trigger
branch
from
4da3f9f to
e757ddb
Compare
| """ | ||
| Remove telescope events that have not the required number of telescopes of | ||
| a given type from the subarray event and decide if the event would | ||
| have triggered the stereo trigger. |
There was a problem hiding this comment.
stereo software? Otherwise this seems very LST-specific.
There was a problem hiding this comment.
This sentence refers to the general stereo trigger of the array, which is not LST specific.
There was a problem hiding this comment.
Indeed, I was biased by my other comment. But this leads to another question: when I read "stereo" (instead of "mono") I think of at least two (>=2), this is not needed here, right? By default a single telescope can trigger this SoftwareTrigger?
There was a problem hiding this comment.
yeah, I think that wording is fine: there are 2 triggeres: the subarray trigger (SWAT) and the LST-Hardware Stereo Trigger. Both are examples of stereo triggers, just different implementations.
| - Ignore events with only 1 telescope after this has been applied | ||
| """ | ||
|
|
||
| min_telescopes = Integer( |
There was a problem hiding this comment.
I am not happy with the naming here, as only the help of the other parameter shows that after applying other checks this one is used. I was very confused when I read the tests (which I did before reading this file), that min_telescopes is (intentionally) lower than sum(min_telescopes_of_type)
maxnoe
force-pushed
the
software_trigger
branch
from
23d0782 to
8623cc5
Compare
maxnoe
force-pushed
the
software_trigger
branch
from
72fd94b to
432e67c
Compare
| tels_with_trigger = set(event.trigger.tels_with_trigger) | ||
| tel_ids = self._ids_by_type[tel_type_str] | ||
| tels_in_event = tels_with_trigger.intersection(tel_ids) |
This trigger allows it to remove lone LST telescope events from array events (as required by the hardware stereo trigger in real life), and to reject events with only one telescope after a subarray has been selected.
maxnoe
force-pushed
the
software_trigger
branch
from
432e67c to
8a49255
Compare
Codecov ReportBase: 92.75% // Head: 92.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2136 +/- ##
=======================================
Coverage 92.75% 92.76%
=======================================
Files 214 216 +2
Lines 17947 18045 +98
=======================================
+ Hits 16647 16739 +92
- Misses 1300 1306 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
No description provided.