Support different frames for set_line_hillas

[StFroese]

Works now for other frames, e.g. EastingNorthing

[codecov]

Codecov Report

Base: 92.74% // Head: 92.74% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8004264) compared to base (56fce14).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2131   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files         214      214           
  Lines       17910    17914    +4     
=======================================
+ Hits        16611    16615    +4     
  Misses       1299     1299           

Impacted Files	Coverage Δ
ctapipe/visualization/mpl_array.py	99.25% <100.00%> (+0.02%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[kosack]

Note that you seem to to have selected the LaPalma alpha telescope id list but applied it to the Paranal array, so that is why you have such a strange-looking array :-) You should use the Paranal-alpha list!

[kosack]

Also, I notice there is still a bug: the points for the line are not correctly transformed (the hillas centroids end up in the wrong place) (sorry didn't even see it until after it was merged!)

[StFroese]

Oh you're right

[StFroese]

Note that you seem to to have selected the LaPalma alpha telescope id list but applied it to the Paranal array, so that is why you have such a strange-looking array :-) You should use the Paranal-alpha list!

I didn't select anything (as far as I know). It's just the file:

source.subarray.info()

Subarray : Paranal-prod6_1-11,19,35
Num Tels : 13
Footprint: 0.59 km2

      Type       Count  Tel IDs  
---------------- ----- ----------
  LST_LST_LSTcam     4 1-4       
MST_MST_FlashCam     9 5-11,19,35