Allow lookup of telescope parameters by type #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.74% // Head: 92.75% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2120 +/- ##
=======================================
Coverage 92.74% 92.75%
=======================================
Files 214 214
Lines 17911 17947 +36
=======================================
+ Hits 16612 16647 +35
- Misses 1299 1300 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Also required for implementing the software trigger, see #1744 |
StFroese
previously approved these changes
Nov 25, 2022
nbiederbeck
previously approved these changes
Nov 25, 2022
LukasNickel
reviewed
Nov 25, 2022
StFroese
previously approved these changes
Nov 25, 2022
nbiederbeck
previously approved these changes
Nov 25, 2022
nbiederbeck
previously approved these changes
Nov 25, 2022
|
flake8 fails because it also fails on latest master |
|
Ok, should be fixed now. Let's merge this first and then I can rebase the others. |
|
Mhh. somehow my commit isn't showing up here although I pushed and it says up-to-date... Github issue? |
nbiederbeck
approved these changes
Nov 25, 2022
|
Ah, now it runs... |
kosack
approved these changes
Nov 25, 2022
StFroese
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows also using the
TelescopeParameterto be used like this:instead of just by telescope id.
This is needed for solving #2119