Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify apply_models #2113

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Simplify apply_models #2113

merged 1 commit into from
Nov 8, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 8, 2022

In preparation of the addition of the disp reconstructors (and also the plugin system), I refactored the apply_models a bit to have already a list of reconstructors.

Right now, these are still loaded from the explicit path traitlets, not from a ComponentNameList(Reconstructor)

@maxnoe maxnoe requested review from kosack, nbiederbeck and LukasNickel and removed request for nbiederbeck November 8, 2022 11:54
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 92.75% // Head: 92.75% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (cfc387c) compared to base (bae863c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2113      +/-   ##
==========================================
- Coverage   92.75%   92.75%   -0.01%     
==========================================
  Files         214      214              
  Lines       17876    17865      -11     
==========================================
- Hits        16581    16570      -11     
  Misses       1295     1295              
Impacted Files Coverage Δ
ctapipe/tools/apply_models.py 95.94% <100.00%> (-0.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxnoe maxnoe merged commit 6d3913a into master Nov 8, 2022
@maxnoe maxnoe deleted the list_of_reconstructors branch November 8, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants