Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding url via env variable #2109

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Allow overriding url via env variable #2109

merged 4 commits into from
Oct 28, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 27, 2022

No description provided.

ctapipe/utils/datasets.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 92.53% // Head: 92.52% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (2ff2c71) compared to base (c19a9f5).
Patch coverage: 88.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2109      +/-   ##
==========================================
- Coverage   92.53%   92.52%   -0.01%     
==========================================
  Files         200      200              
  Lines       16591    16603      +12     
==========================================
+ Hits        15352    15362      +10     
- Misses       1239     1241       +2     
Impacted Files Coverage Δ
ctapipe/utils/datasets.py 88.98% <88.23%> (-0.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

kosack
kosack previously approved these changes Oct 27, 2022
@maxnoe maxnoe requested a review from LukasNickel October 27, 2022 14:00
LukasNickel
LukasNickel previously approved these changes Oct 27, 2022
@maxnoe maxnoe dismissed stale reviews from LukasNickel and kosack via 8507676 October 27, 2022 14:17
@maxnoe maxnoe requested review from kosack and LukasNickel October 27, 2022 14:18
@kosack kosack merged commit e137ecb into master Oct 28, 2022
@kosack kosack deleted the default_url_env branch October 28, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants