Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move impact_distance to coordinates to avoid circular import #2095

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 11, 2022

No description provided.

@maxnoe maxnoe force-pushed the move_impact_distance branch from 5c8309c to 5de39ce Compare October 11, 2022 09:14
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 92.51% // Head: 92.51% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5de39ce) compared to base (89add5c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2095   +/-   ##
=======================================
  Coverage   92.51%   92.51%           
=======================================
  Files         199      200    +1     
  Lines       16561    16563    +2     
=======================================
+ Hits        15322    15324    +2     
  Misses       1239     1239           
Impacted Files Coverage Δ
ctapipe/coordinates/__init__.py 100.00% <100.00%> (ø)
ctapipe/coordinates/impact_distance.py 100.00% <100.00%> (ø)
ctapipe/coordinates/tests/test_impact_distance.py 100.00% <100.00%> (ø)
ctapipe/coordinates/utils.py 100.00% <100.00%> (ø)
ctapipe/io/simteleventsource.py 96.05% <100.00%> (-0.02%) ⬇️
ctapipe/reco/reco_algorithms.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosack kosack merged commit 4ce0998 into master Oct 18, 2022
@kosack kosack deleted the move_impact_distance branch October 18, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants