Convert float32 pi/2 value to float64 pi/2 value in SimTelEventSource #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
force-pushed
the
fix_roundng_error
branch
2 times, most recently
from
f222e8c to
0326e53
Compare
Codecov ReportBase: 92.47% // Head: 92.47% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2077 +/- ##
=======================================
Coverage 92.47% 92.47%
=======================================
Files 197 197
Lines 16276 16276
=======================================
Hits 15052 15052
Misses 1224 1224 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nbiederbeck
reviewed
Sep 21, 2022
nbiederbeck
reviewed
Sep 21, 2022
kosack
previously approved these changes
Sep 21, 2022
maxnoe
force-pushed
the
fix_roundng_error
branch
from
0326e53 to
9380643
Compare
nbiederbeck
previously approved these changes
Sep 21, 2022
LukasNickel
reviewed
Sep 23, 2022
maxnoe
force-pushed
the
fix_roundng_error
branch
from
9380643 to
464f742
Compare
|
Fixed, please review again @LukasNickel @nbiederbeck |
nbiederbeck
approved these changes
Sep 23, 2022
LukasNickel
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes errors that the float32 value of pi/2 is slightly larger than the float64 value of pi/2 and then astropy complains.