Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreachable assertion in Provenance unit test #2072

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

HealthyPear
Copy link
Member

The assertion was inside a fixture after a return statement, so it was never called.

I created a new unit-test that uses the fixture and calls that assertion.

@HealthyPear HealthyPear added missing tests issues concerning missing tests fix labels Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #2072 (4bff97c) into master (428d114) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4bff97c differs from pull request most recent head abf4e62. Consider uploading reports for the commit abf4e62 to get more accurate results

@@           Coverage Diff           @@
##           master    #2072   +/-   ##
=======================================
  Coverage   92.43%   92.43%           
=======================================
  Files         197      197           
  Lines       16183    16185    +2     
=======================================
+ Hits        14958    14960    +2     
  Misses       1225     1225           
Impacted Files Coverage Δ
ctapipe/core/tests/test_provenance.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@HealthyPear HealthyPear force-pushed the fix-provance_unit_test branch from 4bff97c to abf4e62 Compare September 9, 2022 13:24
@kosack kosack merged commit 8c5ea16 into cta-observatory:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix missing tests issues concerning missing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants