Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --datamodel option to ctapipe-info #2047

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

kosack
Copy link
Contributor

@kosack kosack commented Aug 3, 2022

Useful for checking what data models are supported for input and output:

% ctapipe-info --datamodel

*** ctapipe data model ***

output version: v4.0.0
compatible input versions: v4.0.0
change history:

- v4.0.0: - Changed how ctapipe-specific metadata is stored in hdf5 attributes.
            This breaks backwards and forwards compatibility for almost everything.
          - Container prefixes are now included for reconstruction algorithms
            and true parameters.
          - Telescope Impact Parameters were added.
          - Effective focal length and nominal focal length are both included
            in the optics description now. Moved `TelescopeDescription.type`
            to `OpticsDescription.size_type`. Added `OpticsDescription.reflector_shape`.
          - n_samples, n_samples_long, n_channels and n_pixels are now part
            of CameraReadout.
          - The reference_location (EarthLocation origin of the telescope coordinates)
            is now included in SubarrayDescription
          - Only unique optics are stored in the optics table
          - include observation configuration
- v3.0.0: reconstructed core uncertainties splitted in their X-Y components
- v2.2.0: added R0 and R1 outputs
- v2.1.0: hillas and timing parameters are per default saved in telescope frame (degree) as opposed to camera frame (m)
- v2.0.0: Match optics and camera tables using indices instead of names
- v1.2.0: change to more general data model, including also DL2 (DL1 unchanged)
- v1.1.0: images and peak_times can be stored as scaled integers
- v1.0.3: true_image dtype changed from float32 to int32

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #2047 (3365a4f) into master (4739e13) will increase coverage by 0.01%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master    #2047      +/-   ##
==========================================
+ Coverage   92.42%   92.43%   +0.01%     
==========================================
  Files         197      197              
  Lines       16141    16152      +11     
==========================================
+ Hits        14918    14930      +12     
+ Misses       1223     1222       -1     
Impacted Files Coverage Δ
ctapipe/tools/info.py 82.11% <93.33%> (+0.86%) ⬆️
ctapipe/instrument/camera/geometry.py 90.47% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4739e13...3365a4f. Read the comment docs.

@kosack kosack added this to the v0.16.1 milestone Aug 26, 2022
@maxnoe maxnoe merged commit 2804829 into cta-observatory:master Sep 20, 2022
@maxnoe maxnoe modified the milestones: v0.16.1, v0.17.0 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants