Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use n_ prefix consistently, (rename all num_ to n_), fixes #986 #2046

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jul 28, 2022

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #2046 (cb3fa33) into master (8c42f54) will decrease coverage by 0.00%.
The diff coverage is 91.89%.

@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
- Coverage   92.42%   92.42%   -0.01%     
==========================================
  Files         197      197              
  Lines       16034    16030       -4     
==========================================
- Hits        14820    14816       -4     
  Misses       1214     1214              
Impacted Files Coverage Δ
ctapipe/instrument/tests/test_optics.py 100.00% <ø> (ø)
ctapipe/io/simteleventsource.py 96.62% <ø> (ø)
ctapipe/io/eventseeker.py 78.94% <25.00%> (ø)
ctapipe/core/provenance.py 94.02% <66.66%> (ø)
ctapipe/instrument/subarray.py 88.97% <75.00%> (ø)
ctapipe/instrument/guess.py 95.74% <80.00%> (ø)
ctapipe/calib/camera/pedestals.py 95.95% <88.88%> (ø)
ctapipe/calib/camera/flatfield.py 96.03% <90.00%> (ø)
ctapipe/image/muon/intensity_fitter.py 88.65% <92.85%> (ø)
ctapipe/calib/camera/tests/test_flatfield.py 93.02% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c42f54...cb3fa33. Read the comment docs.

@maxnoe maxnoe merged commit a9d2a00 into master Jul 28, 2022
@maxnoe maxnoe deleted the num_vs_n_ branch July 28, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants