Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for by_type split files #2032

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Remove support for by_type split files #2032

merged 1 commit into from
Jul 21, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jul 20, 2022

No description provided.

@maxnoe maxnoe requested a review from kosack July 20, 2022 13:59
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #2032 (2a2fb41) into master (a10e93a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2032   +/-   ##
=======================================
  Coverage   92.36%   92.37%           
=======================================
  Files         193      193           
  Lines       15834    15762   -72     
=======================================
- Hits        14625    14560   -65     
+ Misses       1209     1202    -7     
Impacted Files Coverage Δ
ctapipe/conftest.py 95.40% <ø> (+0.50%) ⬆️
ctapipe/io/datawriter.py 89.96% <100.00%> (-0.14%) ⬇️
ctapipe/io/tableloader.py 98.35% <100.00%> (+1.77%) ⬆️
ctapipe/io/tests/test_table_loader.py 99.42% <100.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10e93a...2a2fb41. Read the comment docs.

Copy link
Contributor

@kosack kosack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had forgot this wasn't already done!

@maxnoe maxnoe merged commit d73bfef into master Jul 21, 2022
@maxnoe maxnoe deleted the remove_by_telid branch July 21, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants