Fix wrong pixel area and rotation in nominal frame, fixes #2028 #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
changed the title
nbiederbeck
previously approved these changes
Jul 20, 2022
LukasNickel
previously approved these changes
Jul 20, 2022
…e in CameraGeometry.transform_to, fixes #2028
maxnoe
force-pushed
the
fix_display_nominal
branch
from
f681f5e to
cb73770
Compare
|
Rtol missing from test, please review again @nbiederbeck @LukasNickel |
nbiederbeck
approved these changes
Jul 20, 2022
Codecov Report
@@ Coverage Diff @@
## master #2029 +/- ##
=======================================
Coverage 92.34% 92.35%
=======================================
Files 193 193
Lines 15811 15823 +12
=======================================
+ Hits 14601 14613 +12
Misses 1210 1210
Continue to review full report at Codecov.
|
LukasNickel
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes translatation and rotation now correctly into account by additionally transforming the origin into the new frame: