Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TableLoader reading empty table #2013

Merged
merged 5 commits into from
Jul 15, 2022
Merged

Fix TableLoader reading empty table #2013

merged 5 commits into from
Jul 15, 2022

Conversation

nbiederbeck
Copy link
Contributor

No description provided.

@nbiederbeck nbiederbeck linked an issue Jul 14, 2022 that may be closed by this pull request
TableLoader.read_telescope_events(tel_ids) fails for empty tables #2011
Closed
@nbiederbeck nbiederbeck changed the title Add failing test Fix TableLoader reading empty table Jul 14, 2022
@nbiederbeck nbiederbeck marked this pull request as ready for review July 14, 2022 13:23
@nbiederbeck nbiederbeck requested a review from maxnoe July 14, 2022 13:23
maxnoe
maxnoe previously approved these changes Jul 14, 2022
View reviewed changes
@maxnoe maxnoe requested a review from kosack July 14, 2022 15:38
@maxnoe maxnoe added the bug label Jul 14, 2022
@maxnoe maxnoe added this to the v0.16.0 milestone Jul 14, 2022
@maxnoe
Copy link
Member

maxnoe commented Jul 14, 2022

This conflicts now

@codecov
Copy link

codecov bot commented Jul 14, 2022 •
edited
Loading

Codecov Report

Merging #2013 (534e8e7) into master (1705e2c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2013   +/-   ##
=======================================
  Coverage   92.35%   92.36%           
=======================================
  Files         193      193           
  Lines       15680    15695   +15     
=======================================
+ Hits        14482    14497   +15     
  Misses       1198     1198
Impacted Files Coverage Δ
ctapipe/instrument/subarray.py 91.25% <100.00%> (+0.06%) ⬆️
ctapipe/io/tableloader.py 96.57% <100.00%> (+0.02%) ⬆️
ctapipe/io/tests/test_table_loader.py 99.50% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1705e2c...534e8e7. Read the comment docs.

@nbiederbeck nbiederbeck force-pushed the fix-tableloader-empty-table branch from 07b06d8 to 534e8e7 Compare July 15, 2022 08:22
@maxnoe maxnoe merged commit 56dacd0 into master Jul 15, 2022
@maxnoe maxnoe deleted the fix-tableloader-empty-table branch July 15, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasNickel LukasNickel LukasNickel approved these changes

@maxnoe maxnoe maxnoe approved these changes

@kosack kosack Awaiting requested review from kosack

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

TableLoader.read_telescope_events(tel_ids) fails for empty tables
3 participants
@nbiederbeck @maxnoe @LukasNickel