Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to read run config and shower distribution to TableLoader #2010

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jul 14, 2022

No description provided.

@maxnoe maxnoe requested review from kosack and nbiederbeck July 14, 2022 08:38
@maxnoe maxnoe added this to the v0.16.0 milestone Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #2010 (2e60e91) into master (ca25ce7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2010      +/-   ##
==========================================
+ Coverage   92.34%   92.35%   +0.01%     
==========================================
  Files         193      193              
  Lines       15658    15680      +22     
==========================================
+ Hits        14460    14482      +22     
  Misses       1198     1198              
Impacted Files Coverage Δ
ctapipe/io/tableloader.py 96.55% <100.00%> (+0.08%) ⬆️
ctapipe/io/tests/test_table_loader.py 99.47% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca25ce7...2e60e91. Read the comment docs.

@maxnoe maxnoe requested a review from LukasNickel July 14, 2022 12:37
@maxnoe maxnoe merged commit 1705e2c into master Jul 14, 2022
@maxnoe maxnoe deleted the table_loader_simulation_configs branch July 14, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants