-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework h5 metadata #2003
Rework h5 metadata #2003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this.
This should also close #1969, I will check my case with this |
Codecov Report
@@ Coverage Diff @@
## master #2003 +/- ##
==========================================
+ Coverage 92.33% 92.35% +0.02%
==========================================
Files 193 193
Lines 15708 15794 +86
==========================================
+ Hits 14504 14587 +83
- Misses 1204 1207 +3
Continue to review full report at Codecov.
|
a0cb235
to
9c8062c
Compare
b20ee6c
to
c136133
Compare
Use in both HDF5TableReader and read_table for less code duplication
dc71182
to
46a5b3e
Compare
This is a draft reworking how we deal with the hdf5 metadata.
CTAFIELD
prefixHDF5TableReader
can now get it from the file metadata and does not have to be provided with prefixes if the mapping from Container field names to column names is unique, an error is raised otherwise.I still have to check performance and file size implications of this, and I would want to also address #1944.
This should fix #1971 and #1785
This breaks reading every file produced previously