Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restriction on existing file in EventSource.input_url, fixes #1821 #1998

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jul 7, 2022

fixes #1821

@maxnoe maxnoe force-pushed the remove_exists_directory branch from fd1b37e to 4b9d9ee Compare July 7, 2022 16:41
@kosack kosack added the fix label Jul 13, 2022
@maxnoe maxnoe marked this pull request as ready for review July 14, 2022 07:57
@maxnoe maxnoe force-pushed the remove_exists_directory branch from 32dd082 to bcf74c5 Compare July 14, 2022 08:02
@maxnoe maxnoe requested review from kosack and nbiederbeck July 14, 2022 08:02
@maxnoe maxnoe added this to the v0.16.0 milestone Jul 14, 2022
@maxnoe maxnoe changed the title Remove restriction on existing file in EventSource.input_url Remove restriction on existing file in EventSource.input_url, fixes #1821 Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1998 (bcf74c5) into master (ca25ce7) will decrease coverage by 0.03%.
The diff coverage is 92.00%.

@@            Coverage Diff             @@
##           master    #1998      +/-   ##
==========================================
- Coverage   92.34%   92.31%   -0.04%     
==========================================
  Files         193      193              
  Lines       15658    15671      +13     
==========================================
+ Hits        14460    14467       +7     
- Misses       1198     1204       +6     
Impacted Files Coverage Δ
ctapipe/io/eventsource.py 90.74% <85.71%> (-1.42%) ⬇️
ctapipe/io/hdf5eventsource.py 89.83% <100.00%> (+0.17%) ⬆️
ctapipe/io/simteleventsource.py 95.14% <100.00%> (+0.05%) ⬆️
ctapipe/core/traits.py 93.54% <0.00%> (-1.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca25ce7...bcf74c5. Read the comment docs.

datalevels = set(metadata["CTA PRODUCT DATA LEVELS"].split(","))
if not datalevels.intersection(("R1", "DL1_IMAGES", "DL1_PARAMETERS")):
if not datalevels.intersection(
("R1", "DL1_IMAGES", "DL1_PARAMETERS", "DL2")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really related, but I guess it was missed before. Fine for me to add the DL2 here

@maxnoe maxnoe merged commit 93527bf into master Jul 15, 2022
@maxnoe maxnoe deleted the remove_exists_directory branch July 15, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple files as input of EventSource
4 participants